Pre commit hooks #18
Merged
Pre commit hooks #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ECS Run as we need to specify the image ECS users
* Import container from ecr repository that is pre-populated
ciaranevans
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Adding pre-commit hooks for linting and auto-formatting. Closes #15
How I did it
Added a
pre-commit-config.yamlwhich follows linting and formatting guidelines from pangeo-forge. Initialized pre-commit hooks in the install-dev section of theMakefile. Fixed existing linting and formatting errors within the repo.How you can test it
Make a commit.