Exclude fsspec.open_kwargs["client_kwargs"] from pattern hash computation

[derekocallaghan]

Fixes #443 using the proposed solution. Corresponding test cases added.

[derekocallaghan]

I'm not sure yet what's causing the test failures. I added a test function to tests/test_serialization.py, but it wasn't run according to the logs. I wouldn't have thought the code changes would cause the current test failures, I'll look into it.

[cisaacstern]

Thanks @derekocallaghan. On first read, both the fix and the test look quite thorough and appropriate to me. I'm also unclear on what's causing the test failure. It seems possibly unrelated to this PR.

[larsbuntemeyer]

Could there be the ssl keyword included in this filtering? It causes similar troubles during hashing and my guess is that it's a similar issue: #418 ?

[derekocallaghan]

It may be easiest to exclude fsspec_open_kwargs itself from the hash computation, rather than filtering a key list containing client_kwargs etc. @cisaacstern, what do you think?

I had a quick look at the stack trace in #418 (comment) and it looks like a separate problem related to pickle. The expected error associated with this PR issue should be raised in pangeo-forge-recipes.serialization.either_encode_or_hash():

pangeo-forge-recipes/pangeo_forge_recipes/serialization.py

Line 25 in fe5d1f7

raise TypeError(f"object of type {type(obj).__name__} not serializable")

e.g.

Input In [5], in either_encode_or_hash(obj)
     13 elif isinstance(obj, bytes):
     14     return obj.hex()
---> 15 raise TypeError(f"object of type {type(obj).__name__} not serializable")

TypeError: object of type ClientTimeout not serializable

[derekocallaghan]

As mentioned by @cisaacstern, the failing tests appear to be unrelated to these PR changes. More details in #451 (comment)