Update index.md #664
Merged
Update index.md #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The data collection that Apache Beam transforms operates on is a | ||
| [`PCollection`](https://beam.apache.org/documentation/programming-guide/#pcollections). | ||
| The data Apache Beam transforms operate on are | ||
| [`PCollections`](https://beam.apache.org/documentation/programming-guide/#pcollections). |
There was a problem hiding this comment.
So do the iterables of a filepattern become pcollections? This is a bit unclear to me.
There was a problem hiding this comment.
Thanks for digging into this, @abarciauskas-bgse!
Yes, this is correct. A FilePattern is iterated over (via .items, not __iter__), and this is converted into a PCollection:
pattern = FilePattern(...)
recipe = beam.Create(pattern.items()) | ...There was a problem hiding this comment.
@abarciauskas-bgse did you want to include any further detail as part of this PR? Or is the current change sufficient for now?
|
This looks fine; merging to clear up backlog though I think we'll want to revisit docs after dealing with the question of laziness of recipes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.