Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide proper error handling in router.Transport #18

Closed
pangiole opened this issue Aug 20, 2016 · 2 comments
Closed

Provide proper error handling in router.Transport #18

pangiole opened this issue Aug 20, 2016 · 2 comments
Assignees
@pangiole
Labels
enhancement

Comments

@pangiole
Copy link
Owner

pangiole commented Aug 20, 2016 •
edited

When the deserialize flow receives a bad incoming message it throws a DeserializeException. The stream could rather drop the offending message and keep the client connected for subsequent messages to come.

This decisions could be implemented with proper Akka Stream Supervision settings.
@pangiole pangiole changed the title Configure proper Akka Stream Supervisor Configure proper Akka Stream Supervision Aug 20, 2016
@pangiole
Copy link
Owner Author

A pull request from luchesar seems to address this issue. Particularly his commit#6196d97

@pangiole pangiole mentioned this issue Aug 21, 2016
Closed
@pangiole pangiole self-assigned this Aug 21, 2016
@pangiole pangiole changed the title Configure proper Akka Stream Supervision Provide proper error handling in router.Transport Aug 21, 2016
@pangiole
Copy link
Owner Author

This issue is related to #20

pangiole added a commit that referenced this issue Aug 21, 2016
@pangiole
(#18) Provide proper error handling in router.Transport
a95dd36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pangiole pangiole

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pangiole