Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed useeffect in approveCallback #497

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: removed useeffect in approveCallback #497

merged 1 commit into from
Jul 25, 2023

Conversation

prodesert22
Copy link
Contributor

Summary

  • Removed useEffect in approve callback because is reseting approve state to not approved

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 6:44pm

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

Last commit released to npm version: 7.3.8-internal.d30cd44

@SarjuHansaliya SarjuHansaliya changed the title feat: removed useeffect in approveCallback fix: removed useeffect in approveCallback Jul 25, 2023
@SarjuHansaliya SarjuHansaliya merged commit 6d05423 into pangolindex:dev Jul 25, 2023
6 of 7 checks passed
@SarjuHansaliya SarjuHansaliya mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarjuHansaliya SarjuHansaliya SarjuHansaliya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prodesert22 @SarjuHansaliya