Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for Static Syntactic Checks #54

Closed
ddmills opened this issue Sep 12, 2015 · 3 comments
Closed

Add Tests for Static Syntactic Checks #54

ddmills opened this issue Sep 12, 2015 · 3 comments
Labels
Milestone

Comments

@ddmills
Copy link
Collaborator

ddmills commented Sep 12, 2015

The syntactic checks (issue #52) will need tests to confirm that they are working.

@ddmills ddmills added this to the v0.1.0-release milestone Sep 12, 2015
@dwtj
Copy link
Collaborator

dwtj commented Sep 12, 2015

We will not be able to test these syntactic checks using the same testing strategy that we have been for previous proc functionality. Previously, we have been running our annotation processor on valid capsule templates. Maven automatically informs us whenever one of the generated artifacts is malformed because of some bug in our proc code. This won't work when we expect some input capsule template to be invalid, because it will crash the entire Maven build.

I propose that we run proc tests (or at least those that we expect to fail) within JUnit tests which trigger javac to compile. Over the summer, I figured out how to run javac from within JUnit tests, so this is possible.

@dwtj
Copy link
Collaborator

dwtj commented Oct 4, 2015

Support for writing tests which only pass upon check failure have been added as of 3dc7ad0.

@dwtj
Copy link
Collaborator

dwtj commented Oct 26, 2015

Tests have been drafted for all current checks as of commit 730afc3.

@dwtj dwtj closed this as completed Oct 26, 2015
@dwtj dwtj mentioned this issue Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants