Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化清理速度并修复内存泄漏 #39

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

wwjiang
Copy link

@wwjiang wwjiang commented Jul 24, 2019

No description provided.

@wwjiang wwjiang force-pushed the master branch 2 times, most recently from d4aa80f to b44a128 Compare July 24, 2019 08:39
@wwjiang wwjiang changed the title 修复获取worker与回收worker之间的死锁 优化清理速度并修复内存泄漏 Jul 24, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #39 into master will decrease coverage by 0.72%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   98.51%   97.78%   -0.73%     
==========================================
  Files           5        5              
  Lines         269      271       +2     
==========================================
  Hits          265      265              
- Misses          2        3       +1     
- Partials        2        3       +1
Impacted Files Coverage Δ
pool.go 98.18% <100%> (+0.03%) ⬆️
ants.go 85.71% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc48d32...b44a128. Read the comment docs.

@panjf2000
Copy link
Owner

panjf2000 commented Jul 24, 2019

这部分修改是参考fasthttp里面的吧,逻辑倒是没什么问题,但是你说原来的写法有内存泄漏,哪里会泄露?

@panjf2000 panjf2000 merged commit 21a109c into panjf2000:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants