opt: make code more formatted

.travis.yml

@@ -29,17 +29,17 @@ before_install:
 
 install:
   - go get -u golang.org/x/lint/golint
-  - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.24.0
+  - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.27.0
   - curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b ~/bin
 
 script:
   - |-
     case $TRAVIS_OS_NAME in
       linux|osx)
         golint ./... | reviewdog -f=golint -reporter=github-check
-        golangci-lint run --out-format=line-number -E gofmt -E golint -E misspell -E lll | reviewdog -f=golangci-lint -reporter=github-check
+        golangci-lint run --out-format=line-number -E goimports -E gocritic -E misspell -E godot | reviewdog -f=golangci-lint -reporter=github-check
         golint ./... | reviewdog -f=golint -reporter=github-pr-review
-        golangci-lint run --out-format=line-number -E gofmt -E golint -E misspell -E lll | reviewdog -f=golangci-lint -reporter=github-pr-review
+        golangci-lint run --out-format=line-number -E goimports -E gocritic -E misspell -E godot | reviewdog -f=golangci-lint -reporter=github-pr-review
         ;;
     esac
   - go test -v ./...

codec.go

@@ -238,7 +238,7 @@ func (cc *LengthFieldBasedFrameCodec) Decode(c Conn) ([]byte, error) {
 		err    error
 	)
 	in = c.Read()
-	if cc.decoderConfig.LengthFieldOffset > 0 { //discard header(offset)
+	if cc.decoderConfig.LengthFieldOffset > 0 { // discard header(offset)
 		header, err = in.readN(cc.decoderConfig.LengthFieldOffset)
 		if err != nil {
 			return nil, errUnexpectedEOF

eventloop_unix.go

@@ -191,8 +191,7 @@ func (el *eventloop) loopCloseConn(c *conn, err error) error {
 	if err0 == nil && err1 == nil {
 		delete(el.connections, c.fd)
 		el.calibrateCallback(el, -1)
-		switch el.eventHandler.OnClosed(c, err) {
-		case Shutdown:
+		if el.eventHandler.OnClosed(c, err) == Shutdown {
 			return errServerShutdown
 		}
 		c.releaseTCP()
@@ -277,8 +276,7 @@ func (el *eventloop) loopReadUDP(fd int) error {
 		el.eventHandler.PreWrite()
 		_ = c.sendTo(out)
 	}
-	switch action {
-	case Shutdown:
+	if action == Shutdown {
 		return errServerShutdown
 	}
 	c.releaseUDP()

examples/custom_codec/client/client.go

@@ -5,10 +5,11 @@ import (
 	"encoding/binary"
 	"errors"
 	"fmt"
-	"github.com/panjf2000/gnet/examples/custom_codec/protocol"
 	"io"
 	"log"
 	"net"
+
+	"github.com/panjf2000/gnet/examples/custom_codec/protocol"
 )
 
 // Example command: go run client.go
@@ -23,7 +24,6 @@ func main() {
 		for {
 
 			response, err := ClientDecode(conn)
-
 			if err != nil {
 				log.Printf("ClientDecode error, %v\n", err)
 			}
@@ -48,7 +48,6 @@ func main() {
 	conn.Write(pbdata)
 
 	select {}
-
 }
 
 // ClientEncode :
@@ -83,7 +82,6 @@ func ClientEncode(pbVersion, actionType uint16, data []byte) ([]byte, error) {
 
 // ClientDecode :
 func ClientDecode(rawConn net.Conn) (*protocol.CustomLengthFieldProtocol, error) {
-
 	newPackage := protocol.CustomLengthFieldProtocol{}
 
 	headData := make([]byte, protocol.DefaultHeadLength)

examples/custom_codec/protocol/pb.go

@@ -72,7 +72,7 @@ func (cc *CustomLengthFieldProtocol) Decode(c gnet.Conn) ([]byte, error) {
 			return nil, errors.New("not normal protocol")
 		}
 		// parse payload
-		dataLen := int(dataLength) //max int32 can contain 210MB payload
+		dataLen := int(dataLength) // max int32 can contain 210MB payload
 		protocolLen := headerLen + dataLen
 		if dataSize, data := c.ReadN(protocolLen); dataSize == protocolLen {
 			c.ShiftN(protocolLen)

examples/custom_codec/server/server.go

@@ -3,11 +3,12 @@ package main
 import (
 	"flag"
 	"fmt"
+	"log"
+	"time"
+
 	"github.com/panjf2000/gnet"
 	"github.com/panjf2000/gnet/examples/custom_codec/protocol"
 	"github.com/panjf2000/gnet/pool/goroutine"
-	"log"
-	"time"
 )
 
 type customCodecServer struct {

examples/echo_tcp/echo.go

@@ -17,6 +17,7 @@ func (es *echoServer) OnInitComplete(srv gnet.Server) (action gnet.Action) {
 		srv.Addr.String(), srv.Multicore, srv.NumEventLoop)
 	return
 }
+
 func (es *echoServer) React(frame []byte, c gnet.Conn) (out []byte, action gnet.Action) {
 	// Echo synchronously.
 	out = frame

examples/echo_udp/echo.go

@@ -17,6 +17,7 @@ func (es *echoServer) OnInitComplete(srv gnet.Server) (action gnet.Action) {
 		srv.Addr.String(), srv.Multicore, srv.NumEventLoop)
 	return
 }
+
 func (es *echoServer) React(frame []byte, c gnet.Conn) (out []byte, action gnet.Action) {
 	// Echo synchronously.
 	out = frame

examples/echo_uds/echo.go

@@ -17,6 +17,7 @@ func (es *echoServer) OnInitComplete(srv gnet.Server) (action gnet.Action) {
 		srv.Addr.String(), srv.Multicore, srv.NumEventLoop)
 	return
 }
+
 func (es *echoServer) React(frame []byte, c gnet.Conn) (out []byte, action gnet.Action) {
 	// Echo synchronously.
 	out = frame

examples/http/http.go

@@ -30,8 +30,10 @@ type httpServer struct {
 	*gnet.EventServer
 }
 
-var errMsg = "Internal Server Error"
-var errMsgBytes = []byte(errMsg)
+var (
+	errMsg      = "Internal Server Error"
+	errMsgBytes = []byte(errMsg)
+)
 
 type httpCodec struct {
 	req request
@@ -144,7 +146,7 @@ func parseReq(data []byte, req *request) (leftover []byte, err error) {
 	var i, s int
 	var head string
 	var clen int
-	var q = -1
+	q := -1
 	// method, path, proto line
 	for ; i < len(sdata); i++ {
 		if sdata[i] == ' ' {

examples/push/push.go

@@ -21,16 +21,19 @@ func (ps *pushServer) OnInitComplete(srv gnet.Server) (action gnet.Action) {
 		"pushing data every %s ...\n", srv.Addr.String(), srv.Multicore, srv.NumEventLoop, ps.tick.String())
 	return
 }
+
 func (ps *pushServer) OnOpened(c gnet.Conn) (out []byte, action gnet.Action) {
 	log.Printf("Socket with addr: %s has been opened...\n", c.RemoteAddr().String())
 	ps.connectedSockets.Store(c.RemoteAddr().String(), c)
 	return
 }
+
 func (ps *pushServer) OnClosed(c gnet.Conn, err error) (action gnet.Action) {
 	log.Printf("Socket with addr: %s is closing...\n", c.RemoteAddr().String())
 	ps.connectedSockets.Delete(c.RemoteAddr().String())
 	return
 }
+
 func (ps *pushServer) Tick() (delay time.Duration, action gnet.Action) {
 	log.Println("It's time to push data to clients!!!")
 	ps.connectedSockets.Range(func(key, value interface{}) bool {
@@ -42,6 +45,7 @@ func (ps *pushServer) Tick() (delay time.Duration, action gnet.Action) {
 	delay = ps.tick
 	return
 }
+
 func (ps *pushServer) React(frame []byte, c gnet.Conn) (out []byte, action gnet.Action) {
 	out = frame
 	return

gnet.go

@@ -114,7 +114,7 @@ type Conn interface {
 	BufferLength() (size int)
 
 	// InboundBuffer returns the inbound ring-buffer.
-	//InboundBuffer() *ringbuffer.RingBuffer
+	// InboundBuffer() *ringbuffer.RingBuffer
 
 	// SendTo writes data for UDP sockets, it allows you to send data back to UDP socket in individual goroutines.
 	SendTo(buf []byte) error