bug: fix the data corruption in some default codecs

codec.go

@@ -81,14 +81,15 @@ func (cc *LineBasedFrameCodec) Encode(c Conn, buf []byte) ([]byte, error) {
 }
 
 // Decode ...
-func (cc *LineBasedFrameCodec) Decode(c Conn) ([]byte, error) {
+func (cc *LineBasedFrameCodec) Decode(c Conn) (b []byte, err error) {
 	buf := c.Read()
 	idx := bytes.IndexByte(buf, CRLFByte)
 	if idx == -1 {
 		return nil, errorset.ErrCRLFNotFound
 	}
+	b = append(b, buf[:idx]...)
 	c.ShiftN(idx + 1)
-	return buf[:idx], nil
+	return
 }
 
 // NewDelimiterBasedFrameCodec instantiates and returns a codec with a specific delimiter.
@@ -102,14 +103,15 @@ func (cc *DelimiterBasedFrameCodec) Encode(c Conn, buf []byte) ([]byte, error) {
 }
 
 // Decode ...
-func (cc *DelimiterBasedFrameCodec) Decode(c Conn) ([]byte, error) {
+func (cc *DelimiterBasedFrameCodec) Decode(c Conn) (b []byte, err error) {
 	buf := c.Read()
 	idx := bytes.IndexByte(buf, cc.delimiter)
 	if idx == -1 {
 		return nil, errorset.ErrDelimiterNotFound
 	}
+	b = append(b, buf[:idx]...)
 	c.ShiftN(idx + 1)
-	return buf[:idx], nil
+	return
 }
 
 // NewFixedLengthFrameCodec instantiates and returns a codec with fixed length.
@@ -126,13 +128,14 @@ func (cc *FixedLengthFrameCodec) Encode(c Conn, buf []byte) ([]byte, error) {
 }
 
 // Decode ...
-func (cc *FixedLengthFrameCodec) Decode(c Conn) ([]byte, error) {
+func (cc *FixedLengthFrameCodec) Decode(c Conn) (b []byte, err error) {
 	size, buf := c.ReadN(cc.frameLength)
-	if size == 0 {
+	if size != cc.frameLength {
 		return nil, errorset.ErrUnexpectedEOF
 	}
+	b = append(b, buf...)
 	c.ShiftN(size)
-	return buf, nil
+	return
 }
 
 // NewLengthFieldBasedFrameCodec instantiates and returns a codec based on the length field.

connection_unix.go

@@ -171,7 +171,7 @@ func (c *conn) Read() []byte {
 		return c.buffer
 	}
 	c.byteBuffer = c.inboundBuffer.WithByteBuffer(c.buffer)
-	return c.byteBuffer.Bytes()
+	return c.byteBuffer.B
 }
 
 func (c *conn) ResetBuffer() {
@@ -197,13 +197,13 @@ func (c *conn) ReadN(n int) (size int, buf []byte) {
 	_, _ = c.byteBuffer.Write(head)
 	_, _ = c.byteBuffer.Write(tail)
 	if inBufferLen >= n {
-		buf = c.byteBuffer.Bytes()
+		buf = c.byteBuffer.B
 		return
 	}
 
 	restSize := n - inBufferLen
 	_, _ = c.byteBuffer.Write(c.buffer[:restSize])
-	buf = c.byteBuffer.Bytes()
+	buf = c.byteBuffer.B
 	return
 }
 

gnet_test.go

@@ -23,6 +23,7 @@ import (
 	"math/rand"
 	"net"
 	"runtime"
+	"strings"
 	"sync/atomic"
 	"testing"
 	"time"
@@ -258,10 +259,9 @@ func testCodecServe(
 		network+"://"+addr,
 		WithMulticore(multicore),
 		WithTicker(true),
+		WithReadBufferCap(8*1024),
 		WithLogLevel(logging.DebugLevel),
-		WithTCPKeepAlive(
-			time.Minute*5,
-		),
+		WithTCPKeepAlive(time.Minute*5),
 		WithSocketRecvBuffer(8*1024),
 		WithSocketSendBuffer(8*1024),
 		WithCodec(codec),
@@ -283,8 +283,9 @@ func startCodecClient(t *testing.T, network, addr string, multicore, async bool,
 	start := time.Now()
 	for time.Since(start) < duration {
 		// data := []byte("Hello, World")
-		data := make([]byte, 1024)
-		rand.Read(data)
+		//data := make([]byte, 1024)
+		//rand.Read(data)
+		data := []byte(strings.Repeat("x", 1024))
 		reqData, _ := codec.Encode(nil, data)
 		_, err = c.Write(reqData)
 		require.NoError(t, err)