chore: rename a function in internal/queue/queue.AsyncTaskQueue

panjf2000 · Nov 30, 2021 · dfa473d · dfa473d
1 parent 148ee16
commit dfa473d
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/internal/netpoll/epoll_default_poller.go b/internal/netpoll/epoll_default_poller.go
@@ -173,7 +173,7 @@ func (p *Poller) Polling(callback func(fd int, ev uint32) error) error {
 				queue.PutTask(task)
 			}
 			atomic.StoreInt32(&p.netpollWakeSig, 0)
-			if (!p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
+			if (!p.asyncTaskQueue.IsEmpty() || !p.priorAsyncTaskQueue.IsEmpty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
 				for _, err = unix.Write(p.wfd, b); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Write(p.wfd, b) {
 				}
 			}

diff --git a/internal/netpoll/epoll_optimized_poller.go b/internal/netpoll/epoll_optimized_poller.go
@@ -175,7 +175,7 @@ func (p *Poller) Polling() error {
 				queue.PutTask(task)
 			}
 			atomic.StoreInt32(&p.netpollWakeSig, 0)
-			if (!p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
+			if (!p.asyncTaskQueue.IsEmpty() || !p.priorAsyncTaskQueue.IsEmpty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
 				for _, err = unix.Write(p.wpa.FD, b); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Write(p.wpa.FD, b) {
 				}
 			}

diff --git a/internal/netpoll/kqueue_default_poller.go b/internal/netpoll/kqueue_default_poller.go
@@ -172,7 +172,7 @@ func (p *Poller) Polling(callback func(fd int, filter int16) error) error {
 				queue.PutTask(task)
 			}
 			atomic.StoreInt32(&p.netpollWakeSig, 0)
-			if (!p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
+			if (!p.asyncTaskQueue.IsEmpty() || !p.priorAsyncTaskQueue.IsEmpty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
 				for _, err = unix.Kevent(p.fd, wakeChanges, nil, nil); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Kevent(p.fd, wakeChanges, nil, nil) {
 				}
 			}

diff --git a/internal/netpoll/kqueue_optimized_poller.go b/internal/netpoll/kqueue_optimized_poller.go
@@ -173,7 +173,7 @@ func (p *Poller) Polling() error {
 				queue.PutTask(task)
 			}
 			atomic.StoreInt32(&p.netpollWakeSig, 0)
-			if (!p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
+			if (!p.asyncTaskQueue.IsEmpty() || !p.priorAsyncTaskQueue.IsEmpty()) && atomic.CompareAndSwapInt32(&p.netpollWakeSig, 0, 1) {
 				for _, err = unix.Kevent(p.fd, wakeChanges, nil, nil); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Kevent(p.fd, wakeChanges, nil, nil) {
 				}
 			}

diff --git a/internal/queue/lock_free_queue.go b/internal/queue/lock_free_queue.go
@@ -152,8 +152,8 @@ retry:
 	goto retry
 }
 
-// Empty indicates whether this queue is empty or not.
-func (q *lockFreeQueue) Empty() bool {
+// IsEmpty indicates whether this queue is empty or not.
+func (q *lockFreeQueue) IsEmpty() bool {
 	return atomic.LoadInt32(&q.length) == 0
 }
 

diff --git a/internal/queue/queue.go b/internal/queue/queue.go
@@ -42,5 +42,5 @@ func PutTask(task *Task) {
 type AsyncTaskQueue interface {
 	Enqueue(*Task)
 	Dequeue() *Task
-	Empty() bool
+	IsEmpty() bool
 }