Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the bug which causes null pointer panic in loopCloseConn #111

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Conversation

hihaha
Copy link
Contributor

@hihaha hihaha commented Jul 9, 2020

name: Pull request
about: Propose changes to the code
title: ''
labels: ''
assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

2. Please describe how these code changes achieve your intention.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #111 into master will increase coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   86.28%   86.50%   +0.21%     
==========================================
  Files          18       18              
  Lines        1400     1400              
==========================================
+ Hits         1208     1211       +3     
+ Misses        162      160       -2     
+ Partials       30       29       -1     
Impacted Files Coverage Δ
eventloop_unix.go 76.82% <0.00%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c6a25...5acbe41. Read the comment docs.

@panjf2000 panjf2000 changed the title issue 110: fix concurrent loopCloseConn causes panic fix: fix the bug which causes null pointer panic in loopCloseConn Jul 9, 2020
@panjf2000 panjf2000 added the pending merged This PR has been reviewed and approved label Jul 9, 2020
Copy link
Owner

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panjf2000 panjf2000 merged commit 329ed32 into panjf2000:master Jul 9, 2020
0-haha pushed a commit to 0-haha/gnet that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants