fix: read goroutine nil pointer panic #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panjf2000
requested changes
Jul 24, 2021
panjf2000
reviewed
Jul 24, 2021
panjf2000
reviewed
Jul 24, 2021
panjf2000
reviewed
Jul 24, 2021
panjf2000
reviewed
Jul 24, 2021
errors/errors.go
Outdated
| @@ -41,6 +41,8 @@ var ( | |||
| ErrUnsupportedUDSProtocol = errors.New("only unix is supported") | |||
| // ErrUnsupportedPlatform occurs when running gnet on an unsupported platform. | |||
| ErrUnsupportedPlatform = errors.New("unsupported platform in gnet") | |||
| // ErrConnectionClosed occurs when connection is closed but eventloop.ch still receive this connection. | |||
There was a problem hiding this comment.
改成 "ErrConnectionClosed occurs when the event-loop receives a closed connection."
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 82.50% 82.35% -0.15%
==========================================
Files 18 18
Lines 1743 1746 +3
==========================================
Hits 1438 1438
- Misses 253 255 +2
- Partials 52 53 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
bug-fixs
2. Please describe how these code changes achieve your intention.
windows下的 listenerRun 也就是 read 操作是一个 goroutine，而另外的 react & write 在另一个 goroutine，并且 write 出错时可能会修改 conn，这个操作必须让 read goroutine 知道，否则会导致 panic，所以做了此修改，
3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist