feat: support so_reuseaddr #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
已重开，这次ok么？ |
Codecov Report
@@ Coverage Diff @@
## dev #280 +/- ##
==========================================
+ Coverage 80.36% 80.49% +0.13%
==========================================
Files 19 19
Lines 1884 1892 +8
==========================================
+ Hits 1514 1523 +9
+ Misses 301 300 -1
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
panjf2000
requested changes
Nov 23, 2021
gnet_test.go
Outdated
| @@ -226,6 +246,7 @@ func testCodecServe( | |||
| multicore, async bool, | |||
| nclients int, | |||
| reuseport bool, | |||
| reuseaddr bool, | |||
There was a problem hiding this comment.
testCodecServe 这个测试里不需要加 reuseaddr 的测试，这里 reuseport 是需要测试不同线程模型，reuseaddr 不需要，所以麻烦这部分测试去掉。
|
Done |
0-haha
pushed a commit
to 0-haha/gnet
that referenced
this pull request
Jan 25, 2023
Fixes panjf2000#266 Fixes panjf2000#272 Co-authored-by: zhongweikang <zhongweikang@sfmail.sf-express.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Are you opening this pull request for bug-fixes, optimizations or new feature?
new feature
2. Please describe how these code changes achieve your intention.
支持 so_reuseaddr 可以使得 gnet 在重启过程中，不必因为 timewait 原因而导致：bind: address already in use
3. Please link to the relevant issues (if any).
ISSUES #266
ISSUES #272
PR #275
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist