Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gnet on Windows #461

Merged
merged 2 commits into from
May 11, 2023
Merged

feat: implement gnet on Windows #461

merged 2 commits into from
May 11, 2023

Conversation

panjf2000
Copy link
Owner

@panjf2000 panjf2000 commented May 9, 2023

Fixes #339

@panjf2000 panjf2000 self-assigned this May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 80.93% and project coverage change: +0.80 🎉

Comparison is base (2e95df1) 76.06% compared to head (93a1d6b) 76.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #461      +/-   ##
==========================================
+ Coverage   76.06%   76.86%   +0.80%     
==========================================
  Files          15       21       +6     
  Lines        1508     2330     +822     
==========================================
+ Hits         1147     1791     +644     
- Misses        279      411     +132     
- Partials       82      128      +46     
Flag Coverage Δ
unittests 76.86% <80.93%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
acceptor_unix.go 42.37% <ø> (ø)
eventloop_unix.go 71.90% <ø> (ø)
listener_unix.go 100.00% <ø> (ø)
connection_unix.go 72.78% <50.00%> (ø)
connection_windows.go 64.52% <64.52%> (ø)
client_windows.go 79.45% <79.45%> (ø)
listener_windows.go 87.93% <87.93%> (ø)
reactor_default_bsd.go 87.32% <88.46%> (-3.16%) ⬇️
reactor_default_linux.go 83.14% <88.46%> (-2.04%) ⬇️
eventloop_windows.go 89.43% <89.43%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000 panjf2000 force-pushed the windows branch 8 times, most recently from e13a05c to ac58458 Compare May 11, 2023 01:28
@panjf2000 panjf2000 added enhancement New feature or request proposal Proposal for this repo pending merged This PR has been reviewed and approved proposal accepted Proposal has been accepted labels May 11, 2023
@panjf2000 panjf2000 force-pushed the windows branch 3 times, most recently from 9ca292f to bfa9b80 Compare May 11, 2023 04:10
@github-actions github-actions bot added the docs label May 11, 2023
@panjf2000 panjf2000 added this to the v2.3.0 milestone May 11, 2023
@panjf2000 panjf2000 merged commit 96f691f into dev May 11, 2023
29 checks passed
@panjf2000 panjf2000 deleted the windows branch May 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request new feature pending merged This PR has been reviewed and approved proposal accepted Proposal has been accepted proposal Proposal for this repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gnet v2 supports Windows
1 participant