Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: invoke the callback whether the connection is open or not #466

Merged
merged 1 commit into from
May 17, 2023

Conversation

panjf2000
Copy link
Owner

Fixes #465

@github-actions github-actions bot added the bug Something isn't working label May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 32.25% and project coverage change: -0.24 ⚠️

Comparison is base (59268af) 77.06% compared to head (00907d7) 76.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #466      +/-   ##
==========================================
- Coverage   77.06%   76.82%   -0.24%     
==========================================
  Files          23       23              
  Lines        2411     2421      +10     
==========================================
+ Hits         1858     1860       +2     
- Misses        420      428       +8     
  Partials      133      133              
Flag Coverage Δ
unittests 76.82% <32.25%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
connection_windows.go 64.52% <0.00%> (ø)
connection_unix.go 71.20% <45.45%> (-1.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000 panjf2000 merged commit 1c1c572 into dev May 17, 2023
51 of 53 checks passed
@panjf2000 panjf2000 deleted the bugfix-465 branch May 17, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: conn.AsyncWrite/AsyncWritev is not called when connection is already closed
1 participant