Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix the data race in test on Windows #472

Merged
merged 3 commits into from
May 24, 2023
Merged

bug: fix the data race in test on Windows #472

merged 3 commits into from
May 24, 2023

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the bug Something isn't working label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.54 ⚠️

Comparison is base (f6de680) 76.97% compared to head (5f8105c) 76.44%.

❗ Current head 5f8105c differs from pull request most recent head 57f2dda. Consider uploading reports for the commit 57f2dda to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #472      +/-   ##
==========================================
- Coverage   76.97%   76.44%   -0.54%     
==========================================
  Files          23       17       -6     
  Lines        2445     1613     -832     
==========================================
- Hits         1882     1233     -649     
+ Misses        429      292     -137     
+ Partials      134       88      -46     
Flag Coverage Δ
unittests 76.44% <ø> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000 panjf2000 merged commit bdcc30c into dev May 24, 2023
25 of 51 checks passed
@panjf2000 panjf2000 deleted the fix-data-race branch May 24, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant