Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: eliminate error logs when the service exits normally #500

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

panjf2000
Copy link
Owner

Fixes #497

@github-actions github-actions bot added the enhancement New feature or request label Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.41% ⚠️

Comparison is base (3f217f9) 77.08% compared to head (9fcb6a2) 76.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #500      +/-   ##
==========================================
- Coverage   77.08%   76.68%   -0.41%     
==========================================
  Files          25       25              
  Lines        2457     2466       +9     
==========================================
- Hits         1894     1891       -3     
- Misses        429      435       +6     
- Partials      134      140       +6     
Flag Coverage Δ
unittests 76.68% <60.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
engine_windows.go 89.47% <33.33%> (-6.32%) ⬇️
acceptor_windows.go 88.23% <62.50%> (-11.77%) ⬇️
listener_windows.go 77.77% <100.00%> (-0.80%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 force-pushed the opt-logs-win branch 4 times, most recently from 3a4aa57 to 17f839b Compare September 10, 2023 11:14
@panjf2000 panjf2000 added optimization Some small optimizations OS-Windows labels Sep 10, 2023
@panjf2000 panjf2000 force-pushed the opt-logs-win branch 3 times, most recently from 9c36b3e to b98c286 Compare September 10, 2023 11:50
@panjf2000 panjf2000 merged commit f7830a4 into dev Sep 10, 2023
31 of 33 checks passed
@panjf2000 panjf2000 deleted the opt-logs-win branch September 10, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations OS-Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: 使用Engine.Stop退出时,会通过DefaultLogger输出很多错误日志
1 participant