Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: read the remaining data after the peer wrote and closed on BSD #531

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

panjf2000
Copy link
Owner

@panjf2000 panjf2000 commented Feb 5, 2024

Fixes #529, along with refactoring a few code.

@github-actions github-actions bot added the bug Something isn't working label Feb 5, 2024
@panjf2000 panjf2000 self-assigned this Feb 5, 2024
@panjf2000 panjf2000 added enhancement New feature or request pending merged This PR has been reviewed and approved optimization Some small optimizations labels Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1bf7af4) 77.30% compared to head (6ce249f) 79.01%.

Files Patch % Lines
reactor_default_bsd.go 71.42% 8 Missing ⚠️
connection_bsd.go 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #531      +/-   ##
==========================================
+ Coverage   77.30%   79.01%   +1.70%     
==========================================
  Files          25       25              
  Lines        2490     2082     -408     
==========================================
- Hits         1925     1645     -280     
+ Misses        430      301     -129     
- Partials      135      136       +1     
Flag Coverage Δ
unittests 79.01% <79.31%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 2694ed7 into dev Feb 5, 2024
33 checks passed
@panjf2000 panjf2000 deleted the kqueue-opt branch February 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request optimization Some small optimizations pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: Server端回包立刻关闭连接,OnTraffic 收不到最后一个包的数据
1 participant