Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable OnOpen for connected UDP socket #554

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Conversation

panjf2000
Copy link
Owner

Fixes #549

@panjf2000 panjf2000 added enhancement New feature or request pending merged This PR has been reviewed and approved optimization Some small optimizations labels Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.08%. Comparing base (54f81b6) to head (9cf2f2d).

Files Patch % Lines
eventloop_unix.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #554      +/-   ##
==========================================
+ Coverage   79.00%   79.08%   +0.08%     
==========================================
  Files          25       25              
  Lines        2091     2109      +18     
==========================================
+ Hits         1652     1668      +16     
- Misses        304      305       +1     
- Partials      135      136       +1     
Flag Coverage Δ
unittests 79.08% <96.77%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 self-assigned this Mar 23, 2024
@panjf2000 panjf2000 merged commit ab69eec into dev Mar 23, 2024
33 checks passed
@panjf2000 panjf2000 deleted the client-udp-onopen branch March 23, 2024 12:08
@panjf2000 panjf2000 added this to the v2.4 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature optimization Some small optimizations pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: enable OnOpen when UDP socket is connected
1 participant