Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support edge-triggered I/O #576

Merged
merged 9 commits into from
Apr 19, 2024
Merged

feat: support edge-triggered I/O #576

merged 9 commits into from
Apr 19, 2024

Conversation

panjf2000
Copy link
Owner

Fixes #573

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 71.70418% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 78.86%. Comparing base (601bfdf) to head (a0fd910).

Files Patch % Lines
reactor_epoll_default.go 65.78% 16 Missing and 10 partials ⚠️
reactor_kqueue_default.go 75.00% 16 Missing and 4 partials ⚠️
eventloop_unix.go 53.12% 10 Missing and 5 partials ⚠️
connection_unix.go 81.13% 8 Missing and 2 partials ⚠️
connection_linux.go 60.00% 3 Missing and 3 partials ⚠️
reactor_epoll_ultimate.go 62.50% 3 Missing ⚠️
reactor_kqueue_ultimate.go 62.50% 3 Missing ⚠️
connection_bsd.go 86.66% 2 Missing ⚠️
engine_unix.go 84.61% 0 Missing and 2 partials ⚠️
acceptor_unix.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #576      +/-   ##
==========================================
- Coverage   79.08%   78.86%   -0.23%     
==========================================
  Files          25       25              
  Lines        2109     2186      +77     
==========================================
+ Hits         1668     1724      +56     
- Misses        305      319      +14     
- Partials      136      143       +7     
Flag Coverage Δ
unittests 78.86% <71.70%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 3860208 into dev Apr 19, 2024
31 of 33 checks passed
@panjf2000 panjf2000 deleted the et-io branch April 19, 2024 13:17
leslie-fei pushed a commit to leslie-fei/gnet that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: support edge-triggered I/O
1 participant