Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix the wrong default behavior of TCPNoDelay on client side #619

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Jun 25, 2024
@panjf2000 panjf2000 added docs patch Release patch version labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (5205c5f) to head (be14468).

Files Patch % Lines
client_unix.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #619      +/-   ##
==========================================
+ Coverage   80.89%   81.03%   +0.14%     
==========================================
  Files          21       21              
  Lines        2109     2109              
==========================================
+ Hits         1706     1709       +3     
+ Misses        273      271       -2     
+ Partials      130      129       -1     
Flag Coverage Δ
unittests 81.03% <50.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 66c2259 into dev Jun 25, 2024
35 of 36 checks passed
@panjf2000 panjf2000 deleted the client-nodelay branch June 25, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs patch Release patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant