feat(Sockets.jl): accept as many connections as possible in one loop #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces (another) buffer, on top of LibUv's 511 connection limit. This buffer aggressively accepts new connections if they are there (with accept_nonblock) and even rejects some of them (this shouldn't exactly happen like that, as TCP doesn't mean HTTP, but this is a demo). The performance difference is negligible (I measure +1% for this PR with a yielding handler, but I expect this to be much more in computation intensive code, and, more importantly, I expect this to handle spikes of traffic better)
WARNING: NOT TESTED, NOT THREADSAFE (...insert any disclaimer here...)
Inspired by libuv/libuv#3071 where it says