Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending Mail fails when using SparkPost SMTP #16

Closed
nianurag opened this issue Jun 16, 2018 · 6 comments
Closed

Sending Mail fails when using SparkPost SMTP #16

nianurag opened this issue Jun 16, 2018 · 6 comments
Assignees
@pankleks
Labels
bug

Comments

@nianurag
Copy link

As no "from" field is included and user field form are not same for this SMTP gateway.
Can I submit the fix?
@pankleks
Copy link
Owner

Go ahead😀

pankleks added a commit that referenced this issue Jun 17, 2018
@pankleks
#16
0c86456
@pankleks pankleks self-assigned this Jun 17, 2018
@pankleks pankleks added the bug label Jun 17, 2018
@pankleks
Copy link
Owner

pankleks commented Jun 17, 2018 •
edited
Loading

@nianurag added to 1.7.3, let me know if works ok

@nianurag
Copy link
Author

nianurag commented Jun 17, 2018 •
edited
Loading

@pankleks Thanks :)
How do I install this specific version 1.7.3?
Looks like you haven't published the module with these changes so confused.

@pankleks
Copy link
Owner

it's released to npm, to install/update use pm2 install pm2-health

@nianurag
Copy link
Author

It works, I got confused earlier as the config didn't have from field. Please add it in the config and mark this as resolved.

@pankleks
Copy link
Owner

from field is optional, that's why it's not added to config. It's mentioned in readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pankleks pankleks

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nianurag @pankleks