Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popconfirm text props to delete button #1628

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

biskuvit
Copy link
Contributor

@biskuvit biskuvit commented Mar 10, 2022

Test me! 'MASTER'
Link to ADD-CONFIRM-TITLE-DELETE-BUTTON

Co-authored-by: Melih Özkalay ozkalai@users.noreply.github.com

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. If not, please add WIP: in its title.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Co-authored-by: Melih Özkalay <ozkalai@users.noreply.github.com>
@biskuvit biskuvit self-assigned this Mar 10, 2022
@refine-bot
Copy link
Contributor

Hello from PR Helper

Is your PR ready for review and processing? Mark the PR ready by including #pr-ready in a comment.

If you still have work to do, even after marking this ready. Put the PR on hold by including #pr-onhold in a comment.

Copy link
Member

@omeraplak omeraplak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool @ozkalai @biskuvit . Could you update docs too?
edit: oh okay it's draft haha

* DeleteButton props updated in the related docs

* fix layout

* Update documentation/docs/ui-frameworks/antd/components/buttons/delete.md

Co-authored-by: Ömer Faruk APLAK <omer@pankod.com>
@omeraplak omeraplak marked this pull request as ready for review March 11, 2022 08:46
@omeraplak omeraplak merged commit 96f1d88 into master Mar 11, 2022
@omeraplak omeraplak deleted the add-confirm-title-delete-button branch March 11, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Allow the customizing of DeleteButton's Popconfirm's props
4 participants