Remove unused prettier dependency #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kachick
added a commit
that referenced
this pull request
Jun 21, 2023
ref: #866, #869 This configuration is not my preference. It keeps zero configration as possible we can. Because I respect the pankona wish as he said as mobu-of-the-world/mobu#489 (comment). --- Ignore files around gitbook Because some of them are generated by tools. And we may drop gitbook dependency. See #870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier is installed but not used anywhere. Some files look formatted, but some are not. CI does not exist around them.
I want to use formatters (especially dprint). But just having a dependency is not useful.
@pankona Do you have any plans to integrate with them?