[#86] fix Ctrl-a/e while editing #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Dec 20, 2018
cmd/hashira-cui/editor.go
Outdated
| @@ -16,13 +17,19 @@ func (e *editor) Edit(v *gocui.View, key gocui.Key, ch rune, mod gocui.Modifier) | |||
| v.MoveCursor(-1, 0, false) | |||
| case gocui.KeyCtrlA: | |||
| // move to start of line | |||
| _, oy := v.Origin() | |||
| v.SetOrigin(0, oy) | |||
There was a problem hiding this comment.
G104: Errors unhandled. (from gosec)
cmd/hashira-cui/editor.go
Outdated
| maxX, _ := v.Size() | ||
| v.MoveCursor(-maxX, 0, false) | ||
| case gocui.KeyCtrlE: | ||
| // move to end of line | ||
| bufLen := len(v.Buffer()) | ||
| _, oy := v.Origin() | ||
| v.SetOrigin(0, oy) |
There was a problem hiding this comment.
G104: Errors unhandled. (from gosec)
golangcibot
reviewed
Dec 20, 2018
| _, oy := v.Origin() | ||
| err := v.SetOrigin(0, oy) | ||
| if err != nil { | ||
| log.Printf("failed to set origin: %v", err) |
There was a problem hiding this comment.
undeclared name: log (from typecheck)
| bufLen := len(v.Buffer()) | ||
| _, oy := v.Origin() | ||
| v.SetOrigin(0, oy) | ||
| if err != nil { |
There was a problem hiding this comment.
undeclared name: err (from typecheck)
pankona
force-pushed
the
86-ctrl-a-e-fix
branch
from
c1ffe4f
to
ff37c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #86
Updates