Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grep through notification channel(s) #82

Closed
nikodemas opened this issue Aug 8, 2023 · 9 comments
Closed

Grep through notification channel(s) #82

nikodemas opened this issue Aug 8, 2023 · 9 comments

Comments

@nikodemas
Copy link
Contributor

Hi @amotl,

Thank you for this tool, it really helps me a lot.

Not sure if I should open this as an issue, but is there a functionality to get information about the notification channels? For example, I needed to see if any of the dashboards are using specific notification channel for the alerting, but I couldn't do it.

If there is no such functionality, do you think it would be possible and useful to implement?

Best regards,
Nikodemas

@amotl
Copy link
Contributor

amotl commented Aug 8, 2023

Dear Nikodemas,

that's a very good idea. I don't think there is a corresponding functionality yet, and relevant patches will be well received, as I think exactly those kinds of investigations are within the very scope of grafana-wtf.

Most probably, some of the fundamental API unlocking would need to go into grafana-client first? Or do you think all the metadata you need is already there and available through data already acquired on behalf of corresponding dashboard representations?

With kind regards,
Andreas.

@nikodemas
Copy link
Contributor Author

Hi Andreas,

thank you for your reply. I am not sure if this functionality requires modifications of the grafana-client first, but I will check and let you know.

Best regards,
Nikodemas

@meyerder
Copy link

meyerder commented Oct 9, 2023

While it is not exactly the same You may find this of use.. in newer versions of grafana where some of it can go into Loki and you can leverage items associated with that as well..

[feature_toggles]
enable = alertStateHistoryLokiSecondary, alertStateHistoryLokiPrimary, alertStateHistoryLokiOnly

@amotl
Copy link
Contributor

amotl commented Oct 9, 2023

Hi @meyerder,

thank you for adding a suggestion here. I have to admit I never used that subsystem of Grafana, so I am currently not able to evaluate this ticket at all, i.e. I don't have any clue ;].

However, I will always be happy to be educated about the problem domain, and this would need to happen in this case, to be able to support users of grafana-wtf in the best way possible.

@nikodemas did not share any references to Grafana API documentation yet, that's why I was asking about whether we need to add corresponding support to grafana-client first. Now, finally looking a bit deeper into what would be needed to resolve this feature request, I am discovering that the API wrapper might already be there 1, and would just need to be consumed by the grafana-wtf find subcommand without further ado.

If you can confirm my observation and conclusion, or correct me where I am wrong, that would be very helpful already. Thank you in advance. 🌻

With kind regards,
Andreas.

Footnotes

  1. https://github.com/panodata/grafana-client/blob/3.9.1/grafana_client/elements/notifications.py

@nikodemas
Copy link
Contributor Author

Hi @amotl,

I checked and it seems that as you said everything is ready on grafana-client, so the updates are only needed on grafana-wtf. I tried to look into the modifications needed for this and included notifications channel in here and here, but it seems that this is not enough. Do I also need to update index? I don't fully understand what needs to be done (and what index is doing overall), but if you give me some guidelines I would be happy to implement the needed changes.

@amotl
Copy link
Contributor

amotl commented Oct 25, 2023

Dear @nikodemas,

your patch GH-105 is a very good start, I will merge it without further ado. The next step, to be able to "grep" through its contents, will probably be to converge or channel [sic!] the outcome so that it can be used by what grafana-wtf find is doing, if that resonates with you?

With kind regards,
Andreas.

@amotl amotl changed the title Grep through notification channel Grep through notification channel(s) Oct 25, 2023
@amotl
Copy link
Contributor

amotl commented Mar 7, 2024

Hi @nikodemas. We just released grafana-wtf 0.18.0, including some of your improvements. Please let us know about other enhancements you may be waiting for, or if it is applicable to close this issue. Thanks again for your contributions!

@nikodemas
Copy link
Contributor Author

nikodemas commented Mar 8, 2024

Hi @amotl, I am not going to work on this and I am not sure if this is needed anymore, so feel free to close it if there are no plans to work on something like this (maybe Close as not planned?)

@amotl
Copy link
Contributor

amotl commented Mar 29, 2024

Hi @nikodemas. Thanks for your reply, and for your contribution on behalf of GH-105, to improve grafana-wtf. It is well appreciated, closing this now. Feel free to re-open any time when applicable.

@amotl amotl closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants