Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid comments containing Liquid replicating #19

Closed
panoply opened this issue Aug 3, 2022 · 0 comments
Closed

Liquid comments containing Liquid replicating #19

panoply opened this issue Aug 3, 2022 · 0 comments
Labels
Critical This is critical defect and needs fixing ASAP Defect Something isn't working, ie: bug or parser defect Liquid Liquid Language

Comments

@panoply
Copy link
Owner

panoply commented Aug 3, 2022

Description

This is a critical defect and needs to be addressed ASAP. Liquid comments containing Liquid code are not being ignored and instead replicated causes serious issues.

Example

Take the following example which is applying omitting code within Liquid comments.

Current
<!-- @prettify-ignore-start -->
{% comment %}

  {%- render 'something' -%} {%- render 'something' -%}  {% endcomment %}

{% endcomment %}
<!-- @prettify-ignore-end -->
Expected
{% comment %}

{%- render 'something' -%} 

{% endcomment %}

Current Workaround

The current approach here is to wrap inline comment ignores:

<!-- @prettify-ignore-start -->
{% comment %}

  {%- render 'something' -%}

{% endcomment %}
<!-- @prettify-ignore-end -->
@panoply panoply added Defect Something isn't working, ie: bug or parser defect Liquid Liquid Language Critical This is critical defect and needs fixing ASAP labels Aug 3, 2022
panoply added a commit that referenced this issue Mar 29, 2023
@panoply panoply closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical This is critical defect and needs fixing ASAP Defect Something isn't working, ie: bug or parser defect Liquid Liquid Language
Projects
None yet
Development

No branches or pull requests

1 participant