Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect warning - video_url setting requires accepts key #189

Open
davidwarrington opened this issue May 2, 2024 · 1 comment
Open

Incorrect warning - video_url setting requires accepts key #189

davidwarrington opened this issue May 2, 2024 · 1 comment
Labels
Bug Something isn't working in the vscode extension 🚢 Shipping Next Release This issue has been completed and will be available next release

Comments

@davidwarrington
Copy link
Collaborator

The video_url property requires accept as a key, and this is correctly suggested via intellisense, but I get an in-editor warning saying Missing property "accepts". Seems like this is just a simple typo
@panoply panoply added Bug Something isn't working in the vscode extension 🚢 Shipping Next Release This issue has been completed and will be available next release labels Jun 13, 2024
@panoply
Copy link
Owner

panoply commented Jun 13, 2024

I'll upstream in Liquify Schema

panoply added a commit to panoply/liquify-schema that referenced this issue Jun 14, 2024
@panoply @davidwarrington
Fixes video_url "accepts" property
5e099b5 
As per: panoply/vscode-liquid#189

Co-Authored-By: David Warrington <9138568+davidwarrington@users.noreply.github.com>
panoply added a commit that referenced this issue Jun 14, 2024
@panoply @davidwarrington
fixes #189 and #175
0000cb5 
Co-Authored-By: David Warrington <9138568+davidwarrington@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working in the vscode extension 🚢 Shipping Next Release This issue has been completed and will be available next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panoply @davidwarrington