Join the threads.

panoptes · May 24, 2024 · 39e0e3f · 39e0e3f
1 parent 3a62f73
commit 39e0e3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/panoptes/pocs/utils/service/power.py b/src/panoptes/pocs/utils/service/power.py
@@ -53,7 +53,8 @@ def record_readings():
     power_thread.start()
 
     yield
-    power_board.logger.info('Shutting down power board')
+    power_board.logger.info('Shutting down power board, please wait.')
+    power_thread.join()
 
 
 app = FastAPI(lifespan=lifespan)

diff --git a/src/panoptes/pocs/utils/service/weather.py b/src/panoptes/pocs/utils/service/weather.py
@@ -33,6 +33,8 @@ async def lifespan(app: FastAPI):
     with suppress(FileNotFoundError):
         ioptron_port = os.readlink('/dev/ioptron')
 
+    weather_thread: Thread = None
+
     # Try to connect to the weather station.
     for port in ports:
         if 'ttyUSB' not in port:
@@ -68,7 +70,8 @@ def record_readings():
         raise RuntimeError('Could not connect to weather station.')
 
     yield
-    weather_station.logger.info('Shutting down weather station')
+    weather_station.logger.info('Shutting down weather station, please wait')
+    weather_thread.join()
 
 
 app = FastAPI(lifespan=lifespan)