Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on missing state transition #1131

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Jun 26, 2021

Logs a warning if not valid transition exists between state and next_state. Still returns parking.

Removes unnecessary variable creation.

Related Issue

Closes #1110

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@b820859). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1131   +/-   ##
==========================================
  Coverage           ?   83.13%           
==========================================
  Files              ?       86           
  Lines              ?     7390           
  Branches           ?      627           
==========================================
  Hits               ?     6144           
  Misses             ?     1074           
  Partials           ?      172           
Impacted Files Coverage Δ
src/panoptes/pocs/__init__.py 100.00% <ø> (ø)
src/panoptes/pocs/base.py 100.00% <ø> (ø)
src/panoptes/pocs/camera/__init__.py 70.78% <ø> (ø)
src/panoptes/pocs/camera/camera.py 84.77% <ø> (ø)
src/panoptes/pocs/camera/gphoto/__init__.py 100.00% <ø> (ø)
src/panoptes/pocs/camera/gphoto/base.py 100.00% <ø> (ø)
src/panoptes/pocs/camera/sdk.py 88.63% <ø> (ø)
src/panoptes/pocs/camera/simulator/ccd.py 94.52% <ø> (ø)
src/panoptes/pocs/camera/simulator/dslr.py 95.58% <ø> (ø)
src/panoptes/pocs/core.py 92.64% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b820859...a0c1735. Read the comment docs.

@wtgee wtgee merged commit 4c79b00 into panoptes:develop Jun 27, 2021
@wtgee wtgee deleted the warn-missing-state-1110 branch June 27, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing state transition silently ignored
1 participant