Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSLR Camera Initialization #1252

Merged
merged 4 commits into from
Apr 30, 2024
Merged

DSLR Camera Initialization #1252

merged 4 commits into from
Apr 30, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Apr 30, 2024

  • When setting default properties of the Canon camera, use the values rather than the index settings, which seem to be more consistent across models.
  • Don't double quote the radio option values.

Closes #1251

* Use the values rather than the index settings, which seem to be more consistent across models.
@wtgee wtgee self-assigned this Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (b93d547) to head (ff76195).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1252      +/-   ##
===========================================
- Coverage    70.22%   70.21%   -0.02%     
===========================================
  Files          100      100              
  Lines         8399     8399              
  Branches      1164     1164              
===========================================
- Hits          5898     5897       -1     
  Misses        2352     2352              
- Partials       149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit e0bb372 into develop Apr 30, 2024
6 of 7 checks passed
@wtgee wtgee deleted the dsrl-init-errors-1251 branch April 30, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSLR camera initialization errors
1 participant