Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small metadata and camera improvements #1253

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 2, 2024

  • Updating current metadata record should clobber, not merge.
  • Changing gphoto2 log entry to a warning.
  • Try to get camera model.

wtgee added 2 commits May 2, 2024 09:26
Updating current metadata record should clobber, not merge.
@wtgee wtgee self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.22%. Comparing base (e0bb372) to head (ff34248).

❗ Current head ff34248 differs from pull request most recent head 737ffe0. Consider uploading reports for the commit 737ffe0 to get more accurate results

Files Patch % Lines
src/panoptes/pocs/utils/cli/network.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1253   +/-   ##
========================================
  Coverage    70.22%   70.22%           
========================================
  Files          100      100           
  Lines         8399     8399           
  Branches      1164     1164           
========================================
  Hits          5898     5898           
  Misses        2352     2352           
  Partials       149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit 6bdacc8 into develop May 2, 2024
5 checks passed
@wtgee wtgee deleted the metadata-improvements branch May 2, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant