Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 #271

Merged
merged 456 commits into from
Dec 30, 2017
Merged

Release 0.6.0 #271

merged 456 commits into from
Dec 30, 2017

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Dec 29, 2017

Updates from 0.5.1.

[0.6.0] - 2017-12-30

Changed

  • Enforce 100 character limit for code 159.
  • Using root-relative module imports 252.
  • Observatory is now a parameter for a POCS instance 195.
  • Better handling of simulator types 200.
  • Log improvements:
    • Separate files for each level and new naming scheme 165.
    • Reduced log format 254.
    • Better reusing of logger 192.
  • Single shared MongoClient connection 228.
  • Improvements to build process 176, 166.
  • State machine location more flexible 209, 219
  • Testing improvments 249.
  • Updates to many wiki pages.
  • Misc bug fixes and improvements.

Added

  • Merge PEAS into POCS 169.
  • Merge PACE into POCS 167.
  • Support added for testing of serial devices 164, 180.
  • Basic dome support 231, 248.
  • Polar alignment helper functions moved from PIAA 265.

Removed

  • Remove threading support from rs232.SerialData 148.

joshwalawender and others added 30 commits August 1, 2016 18:33
* Get rid of print statement that happens too often
* Status line that shows connected sensors (TODO: Show connected port)
wtgee and others added 21 commits December 21, 2017 08:28
Note: This is not ideal because of the hard-coded ports but the fix will
have to wait until we can figure out the port issue in general.
Uses a weakref so that the MongoClient instance is discarded if there are no referrers.
* Explicitly convert equinox to float for FITS header
* This will show a warning but return same file
* Haven't figured out a good way to test it yet.
* Adding some docstrings for the config loaded and save
* Removing 2.0 second delay on opening serial connection until we identify why it is there in the first place.
* Removing unused modules
)

Fix timing of command responses from Astrohaven simulator.
Was emitting response too soon, so driver was skipping past it when
looking for a response, thus never detected that the desired state had
in fact been reached.

Added logging to the Astrohaven simulator to help with future debugging.

Remove obsolete comment. Add clarifying comments about placement of sleep and drain (discard)
operations.
Add a 'dome' attribute to Observatory.

Add logger kwarg to create_dome_from_config, enabling caller to provide logger to be used.

Remove obsolete comment from observatory.py. Add TODO about non-bisque mounts, which assumes all are serial.
Add notes about root-relative imports.
* Add minimal support for domes into POCS.
* Close dome when entering the parking state and when powering down.
* Tests TBS.
…optes#249)

* Make PanBase hermetic across tests by clearing _config each time.
* Replace PanLogger with custom `LogRecord` class
	* Allow logger to use either `%` or `{}` (str.format) style for actual
log messages.
* Log messages show correct file/lineno
* Reorder log.yaml
* Reduced log message format via filter (see example below)
* Add docstring
* Fix logger on messaging
* Remove unused coloredlogs module (will put `grc` info in wiki)

Closes panoptes#253

```
I1228 10:05:01.572 logger.py:112        ****************************** Starting PanLogger ******************************
I1228 10:05:04.897 observatory.py:35    Initializing observatory
I1228 10:05:04.897 observatory.py:38            Setting up location
D1228 10:05:04.897 observatory.py:483   Setting up site details of observatory
```
…noptes#256)

Add opening of the dome to the on_enter method of the ready state.
Add testing with dome to test_pocs.py and test_observatory.py.
Move some testing of PanBase to test_base.py (a new file) from test_pocs.py.
Add open_dome and close_dome commands to pocs_shell.
Add command history to pocs_shell, stored in ~/.pocs_shell_history.
Experiment with adding help to a command in pocs_shell (setup_pocs, in this case).
…panoptes#269)

the PANOPTES logger in peas_shell.
Add command history to peas_shell.
@wtgee wtgee requested a review from a team December 29, 2017 23:34
@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #271 into master will decrease coverage by 1.58%.
The diff coverage is 77.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage    80.6%   79.02%   -1.59%     
==========================================
  Files          36       46      +10     
  Lines        2527     3275     +748     
  Branches      319      426     +107     
==========================================
+ Hits         2037     2588     +551     
- Misses        386      540     +154     
- Partials      104      147      +43
Impacted Files Coverage Δ
pocs/utils/theskyx.py 52.5% <0%> (-2.77%) ⬇️
pocs/utils/messaging.py 75.25% <100%> (ø) ⬆️
pocs/dome/simulator.py 100% <100%> (ø) ⬆️
pocs/mount/__init__.py 100% <100%> (ø)
pocs/version.py 100% <100%> (ø) ⬆️
pocs/scheduler/dispatch.py 96.07% <100%> (+0.24%) ⬆️
pocs/state/states/default/pointing.py 87.75% <100%> (ø) ⬆️
pocs/camera/__init__.py 100% <100%> (ø)
pocs/dome/__init__.py 100% <100%> (+23.25%) ⬆️
pocs/camera/simulator.py 96.29% <100%> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2bc9a...e7b34f9. Read the comment docs.

Copy link
Contributor

@jamessynge jamessynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that is a lot of commits! How can I validate that this represents the right commits? I'll approve on the assumption that you did the right thing, but I can't readily tell.

@wtgee
Copy link
Member Author

wtgee commented Dec 30, 2017

Wow, that is a lot of commits! How can I validate that this represents the right commits? I'll approve on the assumption that you did the right thing, but I can't readily tell.

Yeah, this is the big ugly merge. In the future they shouldn't be like this.

I just followed steps from https://github.com/panoptes/POCS/wiki/Creating-a-New-Release

@wtgee wtgee merged commit eca9fb7 into panoptes:master Dec 30, 2017
@wtgee wtgee deleted the release-0.6.0 branch December 30, 2017 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants