Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset_memo_wise support for private methods #111

Merged
merged 1 commit into from Feb 2, 2021

Conversation

ms-ati
Copy link
Contributor

@ms-ati ms-ati commented Feb 2, 2021

Fixes #110

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #111 (6a6ed81) into main (f094adc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          621       626    +5     
=========================================
+ Hits           621       626    +5     
Impacted Files Coverage Δ
lib/memo_wise.rb 100.00% <100.00%> (ø)
spec/memo_wise_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f094adc...b75f3b9. Read the comment docs.

Copy link
Member

@JacobEvelyn JacobEvelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as that test failed beforehand.

@ms-ati ms-ati merged commit 1258e0a into main Feb 2, 2021
@ms-ati ms-ati deleted the fix-private-methods-reset_memo_wise branch February 2, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: private method support in reset_memo_wise
2 participants