Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class method for preset memo wise #134

Merged
merged 1 commit into from May 15, 2021
Merged

Add class method for preset memo wise #134

merged 1 commit into from May 15, 2021

Conversation

ms-ati
Copy link
Contributor

@ms-ati ms-ati commented Apr 28, 2021 •
edited

Steps:

  • Refactor specs to extract shared examples
  • Add class-level specs for .preset_memo_wise
  • Implement class-level .preset_memp_wise

Closes #86

@codecov
Copy link

codecov bot commented Apr 28, 2021 •
edited

Codecov Report

Merging #134 (0811fa2) into main (9c2262c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0811fa2 differs from pull request most recent head 6274ff9. Consider uploading reports for the commit 6274ff9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              main      #134    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         3            
  Lines          706       573   -133     
==========================================
- Hits           706       573   -133
Impacted Files Coverage Δ
lib/memo_wise.rb 100.00% <100.00%> (ø)
spec/memo_wise_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2262c...6274ff9. Read the comment docs.

@ms-ati ms-ati force-pushed the add-class-method-for-preset_memo_wise branch from 0811fa2 to 8417924 Compare April 28, 2021 20:53
@ms-ati ms-ati requested a review from JacobEvelyn April 29, 2021 13:51
jemmaissroff
jemmaissroff suggested changes Apr 30, 2021
View reviewed changes
lib/memo_wise.rb Show resolved Hide resolved
lib/memo_wise.rb Show resolved Hide resolved
@ms-ati ms-ati force-pushed the add-class-method-for-preset_memo_wise branch from 8417924 to 7398e89 Compare May 14, 2021 21:13
ms-ati
ms-ati commented May 14, 2021
View reviewed changes
lib/memo_wise.rb Outdated Show resolved Hide resolved
@ms-ati ms-ati force-pushed the add-class-method-for-preset_memo_wise branch from 7398e89 to 3028203 Compare May 14, 2021 21:15
@ms-ati
Add class method for preset_memo_wise
6274ff9 
Steps:
  * Refactor specs to extract shared examples
  * Add class-level specs for .preset_memo_wise
  * Implement class-level .preset_memp_wise

Closes #86
@ms-ati ms-ati force-pushed the add-class-method-for-preset_memo_wise branch from 3028203 to 6274ff9 Compare May 14, 2021 21:16
@ms-ati ms-ati merged commit 2b63910 into main May 15, 2021
@ms-ati ms-ati deleted the add-class-method-for-preset_memo_wise branch May 15, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemmaissroff jemmaissroff jemmaissroff approved these changes

@JacobEvelyn JacobEvelyn Awaiting requested review from JacobEvelyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class method for preset_memo_wise
2 participants
@ms-ati @jemmaissroff