Speed up tests by reusing temporary classes/modules #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 173 173
=========================================
Hits 173 173 Continue to review full report at Codecov.
|
JacobEvelyn
force-pushed
the
faster-tests
branch
from
336d70c
to
be4b77a
Compare
JacobEvelyn
force-pushed
the
faster-tests
branch
from
be4b77a
to
960e1fc
Compare
ms-ati
reviewed
Aug 24, 2021
| @@ -13,4 +15,6 @@ class << self | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| let(:module_with_memo) { @_module_with_memo } # rubocop:disable RSpec/InstanceVariable | |||
There was a problem hiding this comment.
Does module_with_memo need the same Module-level resetting of state that the class_with_memo needed?
There was a problem hiding this comment.
I haven't looked into why, but it does not.
ms-ati
reviewed
Aug 24, 2021
ms-ati
approved these changes
Aug 24, 2021
Co-authored-by: Marc Siegel <msiegel@panoramaed.com>
jemmaissroff
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
NOTE: I'm not sure if this is a good idea but it does make our tests much faster.
Before merging:
Copy the table printed at the end of the latest benchmark results into theREADME.mdand update this PRIf this change merits an update toCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning