Fix race conditions in methods with arguments #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobEvelyn
force-pushed
the
thread-safety-improvements
branch
from
d35dda3
to
56e2428
Compare
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 167 167
=========================================
Hits 167 167
Continue to review full report at Codecov.
|
JacobEvelyn
commented
Dec 17, 2021
JacobEvelyn
force-pushed
the
thread-safety-improvements
branch
from
36b4919
to
392a17e
Compare
This commit fixes race conditions found in memoized methods that take arguments. This comes at a slight performance cost for truthy memoized values (due to switching from `Hash#[]` to the slightly slower `Hash#fetch`) but will be faster when memoized values are falsey. This change removes the "truthy optimization" leading to these race conditions and as a result allows us to simplify our benchmark code as we no longer need to benchmark truthy and falsey values separately.
JacobEvelyn
force-pushed
the
thread-safety-improvements
branch
from
392a17e
to
77743aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes race conditions found in memoized methods
that take arguments. This comes at a slight performance cost
for truthy memoized values (due to switching from
Hash#[]to the slightly slower
Hash#fetch) but will be faster whenmemoized values are falsey.
This change removes the "truthy optimization" leading to these
race conditions and as a result allows us to simplify our
benchmark code as we no longer need to benchmark truthy and
falsey values separately.
Before merging:
README.mdand update this PRCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning