Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging with django-simple-currencies fork #22

Closed
bashu opened this issue May 23, 2015 · 9 comments
Closed

Merging with django-simple-currencies fork #22

bashu opened this issue May 23, 2015 · 9 comments

Comments

@bashu
Copy link
Contributor

bashu commented May 23, 2015

Hey,

Can you check my fork here https://github.com/bashu/django-simple-currencies

Notable changes are : using middleware instead of context processor, works with site-wide caching, improved management commands and a lot of clean up

If this changes are okey for you I can backport them via "pull requests" or you can add me as collabarator

@bashu bashu changed the title Merging repos Merging with django-simple-currencies fork May 23, 2015
@panosl
Copy link
Owner

panosl commented Jun 10, 2015

Wow, sorry to keep you waiting that long mate, I've disabled mail notifications and totally missed this one!

I could use help with maintaining currencies, as I'm really spread thin between projects, so if you're interested let me know.

@bashu
Copy link
Contributor Author

bashu commented Jun 11, 2015

Yes sure I can help with maintaining currencies

@panosl
Copy link
Owner

panosl commented Jun 11, 2015

Great! I've added you as a collaborator. Please do not backport middleware etc, yet. Start from current open issues and pull requests, after that we can talk about which features can be backported.

@mafrosis
Copy link

Any progress on this guys? We need to add some caching for all the DB queries and were considering a fork. It would be great to be able to contribute to something useable by others.

@bashu
Copy link
Contributor Author

bashu commented Sep 25, 2015

Hey, I will "fix" that on weekend

@mafrosis
Copy link

👍 Let me know if there is anything I can do to help

bashu added a commit that referenced this issue Sep 26, 2015
merging with django-simple-currencies (models)
bashu added a commit that referenced this issue Sep 26, 2015
merged ``initcurrencies`` and ``updatecurrencysymbols`` into a single…
bashu added a commit that referenced this issue Sep 26, 2015
save currency code in session (rather than Currency object)
@panosl
Copy link
Owner

panosl commented Sep 26, 2015

That's good news :)

On Fri, Sep 25, 2015 at 6:13 PM, Matt Black notifications@github.com
wrote:

[image: 👍] Let me know if there is anything I can do to help


Reply to this email directly or view it on GitHub
#22 (comment)
.

Panos Laganakos
http://panoslaganakos.com

@einarf
Copy link
Contributor

einarf commented Feb 11, 2016

You should get the develop branch down in master asap. Right now the state of what is in master is getting way too outdated and there are compatibility issues out of the box unless you are still using Django 1.5.x :)

There is a reason this project has so many forks. Great stuff in the develop branch. Merge gogogo!

@panosl
Copy link
Owner

panosl commented May 17, 2016

Merged the develop branch into master, just checking stuff and will put a release out to PyPI.

@panosl panosl closed this as completed May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants