Other currency sources #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 2, 2016 20:33
Separated out currency source from command code and made modular. Added command code for specifying base and desired currency source. Started to integrate yahoo finance.
…ary unique constraint on name.
Added feature for grabbing import currency list and base currency from settings. Only tested on python 3.5.2.
|
It would be great if we could have some form of testing though, feel free to make another pull request so we can have this fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've completely refactored the management commands (maintaining backward compatibility of course) to add in some new features and Yahoo Finance integration. New features and advantages:
Downsides:
Happy to take feedback if there are any major headaches in there but really need to get back to the 'day job' ;) Would love to see this merged!
Check it out!