Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove positional argument call #9

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

sapkos
Copy link

@sapkos sapkos commented Jul 27, 2021

Starting from Airflow 2.1 one should only use keyword arguments in operator calls.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 27, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.21%.

Quality metrics Before After Change
Complexity 3.44 ⭐ 3.44 ⭐ 0.00
Method Length 90.43 🙂 90.50 🙂 0.07 👎
Working memory 12.54 😞 12.64 😞 0.10 👎
Quality 65.31% 🙂 65.10% 🙂 -0.21% 👎
Other metrics Before After Change
Lines 332 332 0
Changed files Quality Before Quality After Quality Change
airflow_home/plugins/airflow_livy/batch.py 65.31% 🙂 65.10% 🙂 -0.21% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
airflow_home/plugins/airflow_livy/batch.py LivyBatchOperator.__init__ 3 ⭐ 179 😞 34 ⛔ 41.19% 😞 Try splitting into smaller methods. Extract out complex expressions
airflow_home/plugins/airflow_livy/batch.py LivyBatchOperator.spill_batch_logs 7 ⭐ 137 😞 10 😞 57.45% 🙂 Try splitting into smaller methods. Extract out complex expressions
airflow_home/plugins/airflow_livy/batch.py LivyBatchOperator.execute 7 ⭐ 102 🙂 10 😞 61.83% 🙂 Extract out complex expressions
airflow_home/plugins/airflow_livy/batch.py LivyBatchOperator.check_spark_app_status 4 ⭐ 112 🙂 10 😞 63.42% 🙂 Extract out complex expressions
airflow_home/plugins/airflow_livy/batch.py LivyBatchSensor.__init__ 2 ⭐ 68 🙂 14 😞 65.05% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@johnlawlor-tomtom
Copy link

@panovvv When will this version be released? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants