Pure go reimplementation #4
Conversation
spheromak
force-pushed
the
pure-go
branch
16 times, most recently
from
f2e3b89
to
e3d91bb
Compare
This should enable cross platform builds as well
|
Changes Unknown when pulling 1a6e65d on pure-go into * on master*. |
| type GitRepo struct { | ||
| Repo *git.Repository | ||
| walker *git.RevWalk | ||
| Repo *git.Repository |
| newVersion *version.Version | ||
| branch string | ||
| branchID string // commit id of the branch latest commit (where we will apply the tag) | ||
| } | ||
|
|
||
| // NewRepo is a constructor for a repo object, parsing the tags that exist | ||
| // The caller is responsible for calling Free() on the embedded Repo when they are done with it |
| @@ -58,56 +55,64 @@ func NewRepo(repoPath string) (*GitRepo, error) { | |||
| return r, nil | |||
| } | |||
|
|
|||
| // Parse tags on repo and | |||
| var versions []*version.Version | ||
| var lastParsedTagRef string | ||
| for _, tag := range tags { | ||
| if v, err := maybeVersionFromTag(tag); err == nil { |
There was a problem hiding this comment.
We can reduce the cognitive overhead by changing this to
if err != nil { continue }
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| r := &GitRepo{ | ||
| Repo: repo, | ||
| walker: w, | ||
| branch: branch, |
There was a problem hiding this comment.
Do we want the NewRepo function to allow empty branch names?
|
|
||
| sort.Sort(version.Collection(versions)) | ||
| // set the current versions | ||
| if itemLen := len(keys); itemLen >= 1 { |
There was a problem hiding this comment.
This could be if len(keys) == 0 { return err }
There was a problem hiding this comment.
then we would need to get the len again to do the end of slice element we get in the following line. Can be simplified with the reverse sort. need to look at it all in that context tho.
|
|
||
| start := false | ||
| for e := l.Back(); e != nil; e = e.Prev() { | ||
| commit := e.Value.(*git.Commit) |
There was a problem hiding this comment.
Can this ever be either another type or return a nil pointer?
| log.Printf("Checking commits from %s to %s ", r.branchID, tagCommit.Id) | ||
|
|
||
| start := false | ||
| for e := l.Back(); e != nil; e = e.Prev() { |
There was a problem hiding this comment.
This might be comment worthy. Something like,
Chronologically (oldest to newest) process commit history
| } | ||
|
|
||
| return nil | ||
| return r.tagNewVersion() | ||
| } | ||
|
|
||
| func (r *GitRepo) tagNewVersion() error { | ||
| // TODO:(jnelson) These should be configurable? Mon Sep 14 12:02:52 2015 |
There was a problem hiding this comment.
yea probably should be able to configure that.
| @@ -203,7 +221,7 @@ func (r *GitRepo) tagNewVersion() error { | |||
| func (r *GitRepo) parseCommit(commit *git.Commit) (*version.Version, error) { | |||
| var b bumper | |||
| msg := commit.Message() | |||
| log.Println("Parsing ", msg, ":") | |||
| log.Printf("Parsing %s: %s", commit.Id, msg) | |||
There was a problem hiding this comment.
Do we want a \n in the format string? (this comment might apply to multiple output messages in this repo).
|
Changes Unknown when pulling 65ae775 on pure-go into * on master*. |
|
Changes Unknown when pulling ae47610 on pure-go into * on master*. |
|
@kf6nux addressed most the comments except the append stuff since I am not sure what you are saying we should do there. |
Moving away from libgit to somehting more portable. Also fixing a bug where major doesn't set the minor and patch to 0 when it bumps
This change is