Update Method of Passing DB Credentials

[populist]

-- Define $databases in a cleaner way with checking to see if it is already set
-- Do not use the $$ global variable override. Iterate through known global variables.

[populist]

We pass this information using $_ENV as follows:

array (
  'DB_HOST' => '10.223.176.79',
  'DB_PORT' => '16333',
  'DB_USER' => 'pantheon',
  'DB_PASSWORD' => 'lolpasswordasdsadsa',
  'DB_NAME' => 'pantheon',
)

[joshkoenig]

All the variables we need should be there already, but agreed we want to get away from $$ candy-flipping.

I thought the idea was to do this in a pantheon.settings.php in a nice clean way?

[greg-1-anderson]

Currently this is done in pantheon.settings.php.

Drupal 8 currently loads the settings.php file from Drupal\Core\Site\Settings:: initialize().

We might be able to populate $databases by calling Database::setMultipleConnectionInfo() directly. However, the problem with doing this is that we would then have to special-case the target platform in the prepend file. If Drupal changed the name of this method at some point, then the prepend file would need to know exactly which version of Drupal was installed in order to do the right thing. While this is unlikely, I think that the existing technique is more stable. I suggest we keep this as-is.

[greg-1-anderson]

So, we need to do some things via settings.php modifications, but we could certainly clean up the way in which we do this.