[BUGS-5914] Send the header to the result and not the server #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
I think this fix makes sense, thanks @srtfisher! Setting a header on the actual response rather than unconditionally sending it will fix the issue.
jazzsequence
changed the title
jazzsequence
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending the header to the server, attach the header to the response.
This fixes an issue when
rest_preload_api_request()is used to preload a REST API request. This causes aCannot modify header information - headers already sent by ...error because the code was trying to send the header directly in the preloaded request. The plugin should instead append the headers to the REST response vs outputting it straight away.