[BUGS-6934] Gracefully handle archive pages with multiple post types #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
reviewed
Oct 10, 2023
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
pwtyler
approved these changes
Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where archive pages with multiple post types throws a PHP array to string conversion warning.
get_query_varcan return an array or a string, depending on the query. Previously we were assumingget_query_var( 'post_type' )would only ever return a string. Most of the time this would be true, but there are cases where it is not.This PR adds tests against this scenario and adds handling that runs a
is_arraycheck onget_query_var( 'post_type' )and if it is an array, emits surrogate keys for each post type.this PR also creates a new Factory that extends the base WP Unit Test factory to avoid dynamically creating it and throwing PHP 8 deprecation warnings.