Switch docker image to new 8.x-php8.4 tag. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzsequence
reviewed
Nov 4, 2021
| @@ -41,23 +41,10 @@ jobs: | |||
| - name: Code sniff | |||
| run: composer run-script code:lint | |||
|
|
|||
| - name: Install Terminus | |||
There was a problem hiding this comment.
Is terminus already installed at another step?
There was a problem hiding this comment.
It's in the docker image
|
|
||
| - name: Install Terminus Build Tools | ||
| run: | | ||
| t3 self:plugin:install terminus-build-tools-plugin |
There was a problem hiding this comment.
These are used so in some of the Robo workflows. Is there some other place that the build tools are being installed?
There was a problem hiding this comment.
It's in the docker image
jazzsequence
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should be using a Pantheon official image and ideally, that image should contain terminus and build tools in it. I'm switching the image in this PR.