Incomplete BitBucket Pagination Methods

[ataylorme]

src/API/Bitbucket/BitbucketAPI.php has placeholder methods. These should be updated with proper logic to parse the BitBucket API.

• isPagedResponse
• getPagerInfo
• isLastPage
• getNextPageUri

[ataylorme]

See the GitHub and GitLab implementations for examples

[danielbachhuber]

@ataylorme What's the best way to reproduce this?

[ataylorme]

Pagination kicks in when there are more items returned by the API than can fit in a single request.

I'm not sure where pagination kicks in for BitBucket API requests but terminus build:env:delete:pr with a lot of open PRs would probably trigger it.

[ataylorme]

See https://developer.atlassian.com/bitbucket/api/2/reference/meta/pagination

[danielbachhuber]

It looks like branchesForPullRequests() is the only method that makes a pagedRequest():

terminus-build-tools-plugin/src/ServiceProviders/RepositoryProviders/Bitbucket/BitbucketProvider.php

Line 127 in 637704d

$data = $this->api()->pagedRequest("repositories/$target_project/pullrequests", $callback, ['state' => implode('&state=', $stateParameters[$state])]);

branchesForPullRequests() is called by eligibleIfClosedPrExists():

terminus-build-tools-plugin/src/Utility/MultiDevRetention.php

Lines 101 to 104 in 9005ef3

	public function eligibleIfClosedPRExists()
	{
	return $this->provider->branchesForPullRequests($this->project, 'all', $this);
	}

[ataylorme]

Yes, branchesForPullRequests() is used by build:env:delete:pr to determine which multidev branches correspond with open PRs and which should be deleted (closed PRs).