Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redoing upstream code check logic. Adding additional language for missing environments. #103

Merged

Conversation

erik-pantheon
Copy link
Contributor

Redoing upstream code check logic. Adding additional language for missing environments. The current code returns a positive on the updates check even if the site is up to date with the upstream.

@mikevanwinkle
Copy link
Contributor

When I test this it says dev hasn't been created. I think that's because you should replace !empty() with isset(). If the
if $upstream->test->is_up_to_date_with_upstream is set to false then !empty($upstream->test->is_up_to_date_with_upstream) returns false, while isset($upstream->test->is_up_to_date_with_upstream) would return true.


```+-------------+------------------------------+
| Environment | Status                       |
+-------------+------------------------------+
| dev         | Environment not created yet. |
| test        | Environment not created yet. |
| live        | Environment not created yet. |
+-------------+------------------------------+```

@erik-pantheon
Copy link
Contributor Author

'k. isset() wasn't returning properly when I ran it on my local, so I swapped to the !empty. Let me give that another go. Thanks! - E

@erik-pantheon
Copy link
Contributor Author

@mikevanwinkle Updated code to reflect the [behind] value return and lack of API return for Test and Live environments.

@mikevanwinkle
Copy link
Contributor

👍

mikevanwinkle added a commit that referenced this pull request Feb 5, 2015
Redoing upstream code check logic. Adding additional language for missing environments.
@mikevanwinkle mikevanwinkle merged commit d44146d into pantheon-systems:master Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants