Make the session helper injectable #1197
Conversation
|
@ronan, thanks for your PR! By analyzing the blame information on this pull request, we identified @greg-1-anderson and @TeslaDethray to be potential reviewers |
ronan
force-pushed
the
change/di-sessions
branch
from
2411920
to
b5b2ecb
Compare
| $session = $this->cache->getData('session'); | ||
| $this->data = $session; | ||
| if (empty($session)) { | ||
| $this->data = new \stdClass(); |
There was a problem hiding this comment.
Is an anonymous object the best way to represent this? If it needs any methods, could it be a full fledged class like Pantheon\Terminus\Session\Data or would it be well served as an array?
There was a problem hiding this comment.
If you feel like being lazy with your types, could I recommend class SessionData extends \ArrayObject? You can use it like an array today, but it can also be used for typehinting, and you can add accessors to it later. Win.
There was a problem hiding this comment.
I dunno. I think this should be an array probably but this thing was a pretty lazy copy from the old version. It'll need to be refactored once Auth() is refactored to use it. For now I say leave this be.
|
+1 |
ronan
force-pushed
the
change/di-sessions
branch
from
b5b2ecb
to
c03ef0c
Compare
| * Test destroying the session | ||
| */ | ||
| public function testDestroy() { | ||
| $data = [ |
ronan
force-pushed
the
change/di-sessions
branch
from
592469f
to
9dff715
Compare
1 similar comment
No description provided.