Allow remote commands to work on sandboxen #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernate nameserver, if selected.
jabxjab
approved these changes
Nov 17, 2021
jabxjab
reviewed
Nov 17, 2021
| * | ||
| * @return string | ||
| */ | ||
| private function lookupHostViaAlternateNameserver($host) |
There was a problem hiding this comment.
@greg-1-anderson Should we type hint method args and return values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look up host for 'terminus drush' / 'terminus wp' commands via an alternate nameserver, if selected.
In order for this to work, Terminus also needs access to the \Net_DNS2_Resolver class. There are two ways we could provide this:
composer require pear/net_dns2in Terminus itselfThe advantage of option #2 is that it keeps pear/net_dns2 out of the distribution terminus.phar, since most users won't need it.
Add
TERMINUS_ALTERNATE_NAMESERVER=eco.onebox.panth.ioto your termineco alias to use this with sandbox-eco.